[pgpool-hackers: 4457] Re: Fix white spaces in list type configuration parameters

Tatsuo Ishii ishii at sraoss.co.jp
Wed May 8 18:17:55 JST 2024


> Ishii-san,
> 
> Thank you for reviewing my patch.
> 
>> Our coding standard requires that the variable "i" should be declared
>> prior to any executable statement in a block.
> 
> The attached patch fixes the issue you pointed out.

Looks good to me.

BTW, which branches are you going to push to? In my opinion, since
removing leading/trailing spaces is a user visible change, we should
push to the master branch only. Also it would be nice if you document
that leading/trailing spaces in those string list types are removed.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list