[pgpool-hackers: 4458] Re: Fix white spaces in list type configuration parameters

Bo Peng pengbo at sraoss.co.jp
Thu May 9 08:32:23 JST 2024


Ishii-san,

> BTW, which branches are you going to push to? In my opinion, since
> removing leading/trailing spaces is a user visible change, we should
> push to the master branch only. Also it would be nice if you document
> that leading/trailing spaces in those string list types are removed.

Yes. I will push to master branch only.
Also I will add the documentation.

On Wed, 08 May 2024 18:17:55 +0900 (JST)
Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > Ishii-san,
> > 
> > Thank you for reviewing my patch.
> > 
> >> Our coding standard requires that the variable "i" should be declared
> >> prior to any executable statement in a block.
> > 
> > The attached patch fixes the issue you pointed out.
> 
> Looks good to me.
> 
> BTW, which branches are you going to push to? In my opinion, since
> removing leading/trailing spaces is a user visible change, we should
> push to the master branch only. Also it would be nice if you document
> that leading/trailing spaces in those string list types are removed.
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS LLC
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS LLC
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/


More information about the pgpool-hackers mailing list