[pgpool-hackers: 4456] Re: Fix white spaces in list type configuration parameters

[Bo Peng]

Ishii-san,

Thank you for reviewing my patch.

> Our coding standard requires that the variable "i" should be declared
> prior to any executable statement in a block.

The attached patch fixes the issue you pointed out.

On Wed, 08 May 2024 16:08:13 +0900 (JST)
Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > Currentlly, if the list type configuration parameters 
> > (e.g. unix_socket_directories, pcp_socket_dir, etc.)
> > contain white spaces, it may cause startup failure.
> > 
> > For example:
> > 
> >  unix_socket_directories = ' /tmp , /var/run/postgresql '
> > 
> > It will casue the following errors:
> > 
> >   LOG:  create socket files[0]:  /tmp /.s.PGSQL.11000
> >   FATAL:  failed to bind a socket: " /tmp /.s.PGSQL.11000"
> >   DETAIL:  bind socket failed with error: "No such file or directory"
> > 
> > The attached patch fixes this issue.
> 
> Looks good except this:
> +		int i = strlen(token) - 1;
> 
> Our coding standard requires that the variable "i" should be declared
> prior to any executable statement in a block.
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS LLC
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS LLC
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_white_spaces_v2.patch
Type: application/octet-stream
Size: 706 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240508/8306bfd3/attachment.obj>