[pgpool-hackers: 4455] Re: Fix white spaces in list type configuration parameters

Tatsuo Ishii ishii at sraoss.co.jp
Wed May 8 16:08:13 JST 2024


> Currentlly, if the list type configuration parameters 
> (e.g. unix_socket_directories, pcp_socket_dir, etc.)
> contain white spaces, it may cause startup failure.
> 
> For example:
> 
>  unix_socket_directories = ' /tmp , /var/run/postgresql '
> 
> It will casue the following errors:
> 
>   LOG:  create socket files[0]:  /tmp /.s.PGSQL.11000
>   FATAL:  failed to bind a socket: " /tmp /.s.PGSQL.11000"
>   DETAIL:  bind socket failed with error: "No such file or directory"
> 
> The attached patch fixes this issue.

Looks good except this:
+		int i = strlen(token) - 1;

Our coding standard requires that the variable "i" should be declared
prior to any executable statement in a block.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list