[pgpool-hackers: 4465] abnormal behavior about PGPOOL RESET. and proposal a patch file.

[keiseo]

Hello, and nice to meet you guys.

kashif_zeeshan(kashif.z at bitnine.net) found the abnormal query result with a specific query that is "PGPOOL RESET" query.

He shared this to me and I also had a same thing.

especially this bug only occurred when with watchdog is enabled.

I just do test some with regression test number 4 (watchdog) with fixing this one.

This is the text result.

before fixing.
-----------------
seo at seo-ThinkPad-E14-Gen-2:~$ psql -p 11000 test
psql (15.3)
Type "help" for help.

test=# PGPOOL RESET client_idle_limit;
ERROR: Pgpool node id file �0/pgpool_node_id does not exist
DETAIL: If watchdog is enable, pgpool_node_id file is required
test=# PGPOOL RESET client_idle_limit;
SET
ERROR: Pgpool node id file �y/pgpool_node_id does not exist
DETAIL: If watchdog is enable, pgpool_node_id file is required
message type 0x5a arrived from server while idle
message type 0x43 arrived from server while idle
message type 0x5a arrived from server while idle
test=#

after fixing.
-----------------
eo at seo-ThinkPad-E14-Gen-2:~$ psql -p 11000 test
psql (15.3)
Type "help" for help.

test=# PGPOOL RESET client_idle_limit;
SET
test=# PGPOOL RESET client_idle_limit;
SET
test=# PGPOOL RESET client_idle_limit;
SET
test=#

And also there's some explanation about why I do this and what I want to do in patch file.

Could you please review this patch?

If this is not a bug or only occurs for me, this patch should be abandoned. but that's also good for the pgpool because there's nothing matter on it!

oh well, I read the guideline but this is the first time sending a mail to hackers..

if I missed something, sorry about that and please tell me.

Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240607/7430ac8a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-PGPOOL-RESET-query-with-watchdog.patch
Type: text/x-patch
Size: 2603 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240607/7430ac8a/attachment.bin>