[pgpool-hackers: 3403] Re: Failover consensus on even number of nodes

[Muhammad Usama]

Hi Ishii-San

Thanks for pointing out the missing test case patch, I have committed the
patch after making a few
minor changes, mostly the changes are related to the documentation part and
also I have changed
the configuration parameter name to "enable_consensus_with_half_votes".

Thanks
Best Regards
Muhammad Usama

On Thu, Aug 29, 2019 at 3:37 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > Hi Usama,
> >
> >> Hi Ishii-San,
> >>
> >> The patch looks good overall, but I have few observations.
> >>
> >> First I don't think we needed the changes in the
> >> get_mimimum_nodes_required_for_quorum()
> >> function, Since the function, returns the int so the change are no-op I
> >> believe.
> >>
> >> Also, I think we need kind of similar changes in
> >> compute_failover_consensus() where we are checking
> >> if we have got enough votes for failover as we have done in
> >> update_quorum_status() function.
> >>
> >> So I have updated your patch a little bit. Can you see if the changes I
> >> made looks good to you?
> >
> > Thanks. I will look into this.
>
> For me your patch works as expected. However it seems you forgot to
> patch regression test 004.watchdog, which I already proposed in
> upthread. Patch reattached.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190829/7fb8886b/attachment.html>