[pgpool-hackers: 3402] Re: Failover consensus on even number of nodes

[Tatsuo Ishii]

> Hi Usama,
> 
>> Hi Ishii-San,
>> 
>> The patch looks good overall, but I have few observations.
>> 
>> First I don't think we needed the changes in the
>> get_mimimum_nodes_required_for_quorum()
>> function, Since the function, returns the int so the change are no-op I
>> believe.
>> 
>> Also, I think we need kind of similar changes in
>> compute_failover_consensus() where we are checking
>> if we have got enough votes for failover as we have done in
>> update_quorum_status() function.
>> 
>> So I have updated your patch a little bit. Can you see if the changes I
>> made looks good to you?
> 
> Thanks. I will look into this.

For me your patch works as expected. However it seems you forgot to
patch regression test 004.watchdog, which I already proposed in
upthread. Patch reattached.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quorum-test.diff
Type: text/x-patch
Size: 843 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190829/bf0e2b01/attachment-0001.bin>