[pgpool-hackers: 3371] Re: Fwd: [PATCH] Absolute passwordfile path

[Danylo Hlynskyi]

Added docs change (for english only) and formatted as suggested.

ср, 7 серп. 2019 о 10:17 Tatsuo Ishii <ishii at sraoss.co.jp> пише:

> > The pool_passwd option [1] is specified relative to config file. But for
> > greater flexibility absolute path should be accepted as well.
> >
> > If pool_passwd option starts with /, let's treat it as absolute path.
> > Otherwise, it is treated as relative path.
> >
> > Patch attached. Original author - Derek Kulinski [2]. In NixOS,
> > configuration files often end up in world readable store, which is not
> the
> > best place for storing password files.
>
> Would it be possible for you to provide documentation (SGML files) patch?
>
> One small point:
>
> This does not follow PostgreSQL coding standard (we follow it):
>
>                                          dirp, pool_config->pool_passwd);
>                 } else
>                         strlcpy(pool_passwd, pool_config->pool_passwd,
>                                  sizeof(pool_passwd));
>
> This should be:
>
>                                          dirp, pool_config->pool_passwd);
>                 }
>                 else
>                         strlcpy(pool_passwd, pool_config->pool_passwd,
>                                  sizeof(pool_passwd));
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190807/5cb8bfe0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-both-absolute-and-relative-file-paths-for-po.patch
Type: text/x-patch
Size: 1995 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190807/5cb8bfe0/attachment-0001.bin>