[pgpool-hackers: 3370] Re: Fwd: [PATCH] Absolute passwordfile path

[Tatsuo Ishii]

> The pool_passwd option [1] is specified relative to config file. But for
> greater flexibility absolute path should be accepted as well.
> 
> If pool_passwd option starts with /, let's treat it as absolute path.
> Otherwise, it is treated as relative path.
> 
> Patch attached. Original author - Derek Kulinski [2]. In NixOS,
> configuration files often end up in world readable store, which is not the
> best place for storing password files.

Would it be possible for you to provide documentation (SGML files) patch?

One small point:

This does not follow PostgreSQL coding standard (we follow it):

					 dirp, pool_config->pool_passwd);
		} else
			strlcpy(pool_passwd, pool_config->pool_passwd,
				 sizeof(pool_passwd));

This should be:

					 dirp, pool_config->pool_passwd);
		}
		else
			strlcpy(pool_passwd, pool_config->pool_passwd,
				 sizeof(pool_passwd));

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp