[pgpool-committers: 2113] pgpool: Back porting coverity issues fix patch from master branch.

[Muhammad Usama]

Back porting coverity issues fix patch from master branch.
Fix coverity issue:1111377 Unchecked return value
Fix coverity issue:1111381 Logically dead code
Fix coverity issue:1222992 Unchecked return value
Fix coverity issue:1222993 Unchecked return value
Fix coverity issue:1222996 Printf arg type mismatch
Fix coverity issue:1222997 Printf arg type mismatch

For the coverity issue 1222996 and 1222997 the return type of NameListToString function
is changed from string* to char*, and defination of the which is the return type of the function in PostgreSQL source.
and appropriate changes have been made in the code to incorporate this function return type change.

For coverity issue:1222992 1222993 the return type of do_query() function is changed to void from POOL_STATUS.
The function’s return value became insignificant after the introduction of elog API,
After the API do_query() only returns in a successful scenarios and throws an ereport
in case of any error within the function.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=ded3fa823f59b661ed06cb446fa38902b92a3970

Modified Files
--------------
src/auth/pool_auth.c                          |    5 ---
src/context/pool_session_context.c            |   19 ++++++++-
src/include/parser/pool_string.h              |    2 +-
src/include/pool.h                            |    2 +-
src/main/pgpool_main.c                        |   48 ++++++++++++++-------
src/parser/outfuncs.c                         |   56 ++++++++++++++-----------
src/protocol/child.c                          |    5 ++-
src/protocol/pool_process_query.c             |   55 ++++++++++--------------
src/query_cache/pool_memqcache.c              |    9 +---
src/rewrite/pool_lobj.c                       |    7 +---
src/rewrite/pool_timestamp.c                  |   17 +-------
src/streaming_replication/pool_worker_child.c |   27 ++++++++----
src/test/timestamp/main.c                     |    4 +-
src/utils/pool_relcache.c                     |   42 +++++++++++--------
14 files changed, 157 insertions(+), 141 deletions(-)