[pgpool-committers: 2111] pgpool: Back porting coverity issues fix patch from master branch.

[Muhammad Usama]

Back porting coverity issues fix patch from master branch.
Fix coverity issue:1111377 Unchecked return value
Fix coverity issue:1111381 Logically dead code
Fix coverity issue:1222992 Unchecked return value
Fix coverity issue:1222993 Unchecked return value
Fix coverity issue:1222996 Printf arg type mismatch
Fix coverity issue:1222997 Printf arg type mismatch

For the coverity issue 1222996 and 1222997 the return type of NameListToString function
is changed from string* to char*, which is the signature of this function in PostgreSQL source.
and appropriate changes have been made in the code to incorporate this function return type change.

This checkin also fixes the memory leak in NameListToString Function and adds the prototype of same in pool_string.h, That
was causing the compiler warning.

Branch
------
V3_3_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=3b8ee4b461f5d2ce1113fee5c8929e802f0dc344

Modified Files
--------------
child.c                |    5 +++--
main.c                 |   38 ++++++++++++++++++++++----------------
parser/outfuncs.c      |   14 +++++++++-----
parser/pool_string.h   |    4 ++--
pool_auth.c            |    6 ------
pool_session_context.c |   10 +++++++++-
6 files changed, 45 insertions(+), 32 deletions(-)