[pgpool-hackers: 4558] Re: [pgpool-committers: 10307] pgpool: Fix pool_signal.
Tatsuo Ishii
ishii at postgresql.org
Sun Jan 12 19:57:35 JST 2025
>From the thread in pgsql-hackers:
https://www.postgresql.org/message-id/b0afe844-84b7-4154-ad2c-6763ff84d876%40oss.nttdata.com
The signal setting function in PostgreSQL mistakenly forgot to set the
SA_RESTART flag. Pgpool has imported the function from PostgreSQL
long time ago and I checked if we have the same mistake as
PostgreSQL. The answer was unfortunately yes. We do not set SA_RESTART
flag if the signal is SIGALRM. The commit below fixes the issue in
master branch. I will watch the buildfarm result and if the commit
caused bad thing or not. If not, I will back patch to all supported
branches.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
From: Tatsuo Ishii <ishii at postgresql.org>
Subject: [pgpool-committers: 10307] pgpool: Fix pool_signal.
Date: Sun, 12 Jan 2025 05:27:01 +0000
Message-ID: <E1tWqV3-00GL2s-Cn at gothos.postgresql.org>
> Fix pool_signal.
>
> Previously pool_signal did not set SA_RESTART flag. Thus any system
> calls interrupted by a signal does not restart. Some of our code are
> prepared so that they restart if a system call is interrupted by a
> signal. But not sure all places are prepared too. So add the
> flag. Note, PostgreSQL always uses the flag.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=abcff550b1930f1e02b69f3f844eb071d3b18ec8
>
> Modified Files
> --------------
> src/utils/pool_signal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
More information about the pgpool-hackers
mailing list