[pgpool-hackers: 4449] Re: 4.5.1 build error against openldap 2.6.7

[Bo Peng]

Hi,

I have fixed this issue:

https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=c55384a918ff1cc70cddf710f2371cfe9d5491c8

It will be released in the next minor release scheduled on May 16th.

On Sat, 27 Apr 2024 20:41:13 +0900
Bo Peng <pengbo at sraoss.co.jp> wrote:

> Hi Devrim,
> 
> Thank you for reporting this issue.
> 
> I think these errors occur bacause Fedora uses
> "-Werror=implicit-function-declaration" build option.
> 
> Since in the "ldap.h" use #if LDAP_DEPRECATED instead of #ifdef,
> we should add LDAP_DEPRECATED for using deprecated ldap functions.
> 
> I will fix this issue and let you know.
> 
> Best regards,
> 
> On Fri, 26 Apr 2024 15:10:09 +0100
> Devrim Gündüz <devrim at gunduz.org> wrote:
> 
> > 
> > Hi,
> > 
> > I'm seeing these errors (apart from some other GCC warnings unrelated to
> > this email) while building pgpool-II on Fedora 39 and Fedora 40. It
> > builds fine on RHEL 9. The difference is the openldap versions: Fedora
> > ships 2.6.7 where RHEL 9 ships 2.6.3. Any comments? 
> > 
> > Thanks! Devrim
> > ======================================================
> > gcc -DHAVE_CONFIG_H -DDEFAULT_CONFIGDIR=\"/etc/pgpool-II-pg16-extensions\" -DPGSQL_BIN_DIR=\"/usr/pgsql-16/bin\" -I. -I../src/include  -D_GNU_SOURCE -I /usr/pgsql-16/include   -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-format-truncation -Wno-stringop-truncation -fno-strict-aliasing -c -o protocol/pool_connection_pool.o protocol/pool_connection_pool.c
> > auth/pool_hba.c: In function ‘InitializeLDAPConnection’:
> > auth/pool_hba.c:2611:17: error: implicit declaration of function ‘ldap_unbind’; did you mean ‘ldap_txn_end’? [-Wimplicit-function-declaration]
> > 
> > 
> >  2611 |                 ldap_unbind(*ldap);
> >       |                 ^~~~~~~~~~~
> >       |                 ldap_txn_end
> > auth/pool_hba.c: In function ‘CheckLDAPAuth’:
> > auth/pool_hba.c:2779:21: error: implicit declaration of function ‘ldap_simple_bind_s’; did you mean ‘ldap_sasl_bind_s’? [-Wimplicit-function-declaration]
> >  2779 |                 r = ldap_simple_bind_s(ldap,
> >       |                     ^~~~~~~~~~~~~~~~~~
> >       |                     ldap_sasl_bind_s
> > auth/pool_hba.c:2803:21: error: implicit declaration of function ‘ldap_search_s’; did you mean ‘ldap_search_ext’? [-Wimplicit-function-declaration]
> >  2803 |                 r = ldap_search_s(ldap,
> >       |                     ^~~~~~~~~~~~~
> >       |                     ldap_search_ext
> > auth/pool_hba.c:2871:21: error: implicit declaration of function ‘ldap_unbind_s’; did you mean ‘ldap_unbind_ext’? [-Wimplicit-function-declaration]
> >  2871 |                 r = ldap_unbind_s(ldap);
> >       |                     ^~~~~~~~~~~~~
> >       |                     ldap_unbind_ext
> > make[3]: *** [Makefile:864: auth/pool_hba.o] Error 1
> > 
> > -- 
> > Devrim Gündüz Open Source Solution Architect, PostgreSQL Major
> > Contributor Twitter: @DevrimGunduz , @DevrimGunduzTR
> >  * 
> > _______________________________________________
> > pgpool-hackers mailing list
> > pgpool-hackers at pgpool.net
> > http://www.pgpool.net/mailman/listinfo/pgpool-hackers
> 
> 
> -- 
> Bo Peng <pengbo at sraoss.co.jp>
> SRA OSS LLC
> TEL: 03-5979-2701 FAX: 03-5979-2702
> URL: https://www.sraoss.co.jp/
> _______________________________________________
> pgpool-hackers mailing list
> pgpool-hackers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-hackers


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS LLC
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/