[pgpool-hackers: 4482] Re: Watchdog and IPv6

[Kwangwon Seo]

Oh Hi.. It's been a week...

I think I'm too slow! sorry about that.

Anyway, Here's the details and patch files.

- Why chose ipv4-mapped-ipv6 method
Initially, I want to open multiple sockets for ipv4 socket and ipv6 socket just like pgpool process.
but If I do so, I also have to modify struct SocketConnection. because it has one socket descriptor.
That means, the requirements; "we need to fix only 4 functions" is not met.
So I chose ipv4-mapped-ipv6 method.

- Use of asprintf
asprintf() is a GNU extension. not a posix, or C standard.
reference: https://www.gnu.org/software/gnulib/manual/html_node/asprintf.html
But I think it's still good to use. also, there are some usage of asprintf() in the codes.

- Regression tests
I tested 004.watchdog with changing hostnames with all branches which is in range of EOL.

- etc
I also know that quality is the most important thing.
So, If I do something wrong, you can reject my patch or request to me to do something..!

- patch files(attachment)
for V4_1, V4_2, V4_3, V4_4, V4_5, master

Best Regards...


Kwangwon Seo

Bitnine Global Inc.
www.bitnine.net


On Thursday, July 4th, 2024 at 16:30, Tatsuo Ishii <ishii at postgresql.org> wrote:

> > Oh... Can I challenge to that feature implementatation?
> > 
> > I saw that things ago, todo list and github issue also.
> > 
> > And I just saw that you updated about that one.
> > 
> > I was hesitated because I think that is already done or on progress by other developer.
> 
> 
> As far as I know no other developers are working on this.
> 
> > If available, can I do this?
> 
> 
> Sure. Why not. I will volunteer on reviewing your patch.
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS LLC
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: master_0001-feat-supporting-watchdog-ipv6-address.patch
Type: text/x-patch
Size: 12303 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240712/11e49a18/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: V4_3_STABLE_0001-feat-supporting-watchdog-ipv6-address.patch
Type: text/x-patch
Size: 12303 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240712/11e49a18/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: V4_2_STABLE_0001-feat-supporting-watchdog-ipv6-address.patch
Type: text/x-patch
Size: 12305 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240712/11e49a18/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: V4_1_STABLE_0001-feat-supporting-watchdog-ipv6-address.patch
Type: text/x-patch
Size: 12298 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240712/11e49a18/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: V4_4_STABLE_0001-feat-supporting-watchdog-ipv6-address.patch
Type: text/x-patch
Size: 12303 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240712/11e49a18/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: V4_5_STABLE_0001-feat-supporting-watchdog-ipv6-address.patch
Type: text/x-patch
Size: 12303 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20240712/11e49a18/attachment-0011.bin>