[pgpool-hackers: 4358] Re: [pgpool-committers: 9487] pgpool: Disallowing setting the max_spare_children greater than num_ini

[Muhammad Usama]

Hi Ishii San

On Sun, Jul 23, 2023 at 8:21 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > Hi Usama,
> >
> > After this commit regression test starts to fail:
> >
> > testing 012.watchdog_failover_when_quorum_exists...failed.
> > testing 013.watchdog_failover_require_consensus...failed.
> > :
> > :
> >
> > Attached are logs for the tests.
>
> I also wonder this:
>
> >> Config post-processing stage now throws an error if num_init_children is
> >> smaller than max_spare_children.
>
> >> For the Aggressive strategy, max_spare_children number of processes is
> spawned;
> >> for the other two strategies, min_spare_children number of children gets
> >> created at startup.
>
> Shouldn't min_spare_children and max_spare_chidren be ignored if
> process_management_mode = static? From the 4.4 doc:
>

That is the correct way. I have pushed the commit that skips
max and min spare children config values verification when static process
management mode is used.
Thanks for pointing this out.

Best regards
Muhammad Usama

> -------------------------------------------------------------------------
> min_spare_children (integer)
>
>     Specify the minimum number of spare (idle) child processes to
>     keep. If the idle process count falls below min_spare_children,
>     Pgpool-II will spawn new child processes unless it hits the total
>     allowed child process ceiling (num_init_children). Default value
>     is 5.
>     This parameter can be changed by reloading the Pgpool-II
> configurations.
>     This parameter is only applicable for dynamic process management mode.
>
> max_spare_children (integer)
>
>     Specify the maximum number of spare (idle) child processes to
>     keep. If the idle process count increases from max_spare_children,
>     Pgpool-II will kill the excessive child processes. Default value
>     is 10.
>     This parameter can be changed by reloading the Pgpool-II
> configurations.
>     This parameter is only applicable for dynamic process management mode.
> -------------------------------------------------------------------------
>
> > From: Muhammad Usama <m.usama at gmail.com>
> > Subject: [pgpool-committers: 9487] pgpool: Disallowing setting the
> max_spare_children greater than num_ini
> > Date: Sat, 22 Jul 2023 14:26:28 +0000
> > Message-ID: <E1qNDYx-002KBf-7l at gothos.postgresql.org>
> >
> >> Disallowing setting the max_spare_children greater than
> num_init_children.
> >>
> >> Config post-processing stage now throws an error if num_init_children is
> >> smaller than max_spare_children.
> >> Commit also adjusts the number of child processes spawned at startup
> based on
> >> the configured process management strategy.
> >> For the Aggressive strategy, max_spare_children number of processes is
> spawned;
> >> for the other two strategies, min_spare_children number of children gets
> >> created at startup.
> >>
> >> Branch
> >> ------
> >> master
> >>
> >> Details
> >> -------
> >>
> https://url.avanan.click/v2/___https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=37dc683f7f15cbf4502b338937e54b9da0a92efd___.YXAzOnBlcmNvbmE6YTpnOjM4MzE2YzY5NThhZGU2NjI5N2UzNTJjMzI5NThlYTU2OjY6YzYyZjo5YzYwNWJkM2E5NTYxZTEyMzY3MDczNjU2ZGRhZmU2NDhhYTdmZGQ1NGMwZmNmZWM5YWI4NWMwNjM5YjkyM2M2OnA6VA
> >>
> >> Modified Files
> >> --------------
> >> src/config/pool_config_variables.c |  7 +++++++
> >> src/main/pgpool_main.c             | 11 ++++++++---
> >> 2 files changed, 15 insertions(+), 3 deletions(-)
> >>
> _______________________________________________
> pgpool-hackers mailing list
> pgpool-hackers at pgpool.net
>
> https://url.avanan.click/v2/___http://www.pgpool.net/mailman/listinfo/pgpool-hackers___.YXAzOnBlcmNvbmE6YTpnOjM4MzE2YzY5NThhZGU2NjI5N2UzNTJjMzI5NThlYTU2OjY6NGYzZDo4ODllMWYzZjBhYmZkN2EyNzg4Y2Y4MTM4MWQ5MTExMGI5ZTNiZDJlZjc2MmI0ZjlmM2U2MzYyZjY3NmQ1OWExOnA6VA
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20230723/bdd87b2d/attachment.htm>