[pgpool-hackers: 4361] Re: [pgpool-committers: 9503] pgpool: Feature: Import PostgreSQL 16 BETA1 new parser.

[NINGWEI CHEN]

Hi Ishii san,

Sorry about the inconvenience. I think that one needed header include was missed 
and that was the cause of the problem. Fix has been pushed to the master branch.

Best Regards.
-- 
SRA OSS LLC
Chen Ningwei<chen at sraoss.co.jp>

On Mon, 31 Jul 2023 21:07:30 +0900 (JST)
Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Hi,
> 
> Thank you for upgrading our SQL paraser!
> 
> After the commit my compiler complains:
> 
> utils/pgstrcasecmp.c: In function ‘pg_strcasecmp’:
> utils/pgstrcasecmp.c:47:36: warning: implicit declaration of function ‘isupper’ [-Wimplicit-function-declaration]
>    47 |    else if (IS_HIGHBIT_SET(ch1) && isupper(ch1))
>       |                                    ^~~~~~~
> utils/pgstrcasecmp.c:48:11: warning: implicit declaration of function ‘tolower’ [-Wimplicit-function-declaration]
>    48 |     ch1 = tolower(ch1);
>       |           ^~~~~~~
> utils/pgstrcasecmp.c: In function ‘pg_toupper’:
> utils/pgstrcasecmp.c:109:33: warning: implicit declaration of function ‘islower’ [-Wimplicit-function-declaration]
>   109 |  else if (IS_HIGHBIT_SET(ch) && islower(ch))
>       |                                 ^~~~~~~
> utils/pgstrcasecmp.c:110:8: warning: implicit declaration of function ‘toupper’ [-Wimplicit-function-declaration]
>   110 |   ch = toupper(ch);
>       |        ^~~~~~~
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS LLC
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
> 
> From: Chen Ningwei <chen at sraoss.co.jp>
> Subject: [pgpool-committers: 9503] pgpool: Feature: Import PostgreSQL 16 BETA1 new parser.
> Date: Mon, 31 Jul 2023 05:21:21 +0000
> Message-ID: <E1qQLLM-006AV8-7j at gothos.postgresql.org>
> 
> > Feature: Import PostgreSQL 16 BETA1 new parser.
> > 
> > Major changes of PostgreSQL 16 parser include:
> > 
> > - Add new option DEFAULT to COPY FROM
> > 
> >   COPY ... FROM stdin WITH (default 'xx');
> > 
> > - Allow the STORAGE type to be specified by CREATE TABLE
> > 
> >   CREATE TABLE t1 (
> >      c1 VARCHAR(10) STORAGE PLAIN,
> >      c2 TEXT STORAGE EXTENDED
> >   );
> > 
> > - Add EXPLAIN option GENERIC_PLAN to display the generic plan for a parameterized query
> > 
> >   EXPLAIN (GENERIC_PLAN) SELECT ...;
> > 
> > - Allow subqueries in the FROM clause to omit aliases
> > 
> >   SELECT COUNT(*) FROM (SELECT ... FROM ...);
> > 
> > - Add SQL/JSON constructors
> > 
> > - Add VACUUM options
> >   SKIP_DATABASE_STATS, ONLY_DATABASE_STATS to skip or update all frozen statistics
> >   PROCESS_MAIN to only process TOAST tables
> > 
> >   VACUUM (SKIP_DATABASE_STATS);
> >   VACUUM (PROCESS_MAIN FALSE) t1 ;
> > 
> > Branch
> > ------
> > master
> > 
> > Details
> > -------
> > https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=ca300f8391f5963ff69248050b17393b6f93fab3
> > 
> > Modified Files
> > --------------
> > src/include/parser/keywords.h                      |    4 +-
> > src/include/parser/kwlist.h                        |   17 +-
> > src/include/parser/kwlist_d.h                      | 1045 ++++++++++----------
> > src/include/parser/makefuncs.h                     |   13 +-
> > src/include/parser/nodes.h                         |  610 ++----------
> > src/include/parser/nodetags.h                      |  471 +++++++++
> > src/include/parser/parsenodes.h                    |  531 +++++++---
> > src/include/parser/parser.h                        |    4 +-
> > src/include/parser/pg_class.h                      |    4 +-
> > src/include/parser/pg_config_manual.h              |   49 +-
> > src/include/parser/pg_list.h                       |   45 +-
> > src/include/parser/pg_trigger.h                    |    4 +-
> > src/include/parser/pg_wchar.h                      |   11 +-
> > src/include/parser/primnodes.h                     |  893 ++++++++++++-----
> > src/include/parser/scanner.h                       |    6 +-
> > src/include/parser/scansup.h                       |    4 +-
> > src/include/parser/stringinfo.h                    |    8 +-
> > src/include/parser/value.h                         |   16 +-
> > src/include/utils/pgstrcasecmp.h                   |    5 +
> > src/parser/copyfuncs.c                             |   18 +-
> > src/parser/gram.y                                  |  696 +++++++++----
> > src/parser/gram_minimal.y                          |  696 +++++++++----
> > src/parser/gram_template.y                         |  696 +++++++++----
> > src/parser/keywords.c                              |    4 +-
> > src/parser/kwlookup.c                              |    4 +-
> > src/parser/list.c                                  |   52 +-
> > src/parser/makefuncs.c                             |  104 +-
> > src/parser/nodes.c                                 |    4 +-
> > src/parser/outfuncs.c                              |   27 +-
> > src/parser/parser.c                                |   30 +-
> > src/parser/scan.l                                  |  107 +-
> > src/parser/scansup.c                               |    4 +-
> > src/parser/snprintf.c                              |   26 +-
> > src/parser/stringinfo.c                            |   12 +-
> > src/parser/value.c                                 |    4 +-
> > src/parser/wchar.c                                 |  634 ++++++------
> > .../tests/010.rewrite_timestamp/timestamp/Makefile |    2 +
> > src/utils/pgstrcasecmp.c                           |    7 +-
> > 38 files changed, 4444 insertions(+), 2423 deletions(-)
> >