[pgpool-hackers: 4241] Re: Proper declaration for SplitIdentifierString

[Tatsuo Ishii]

Hi,

> Currently, SplitIdentifierString is resolved via an implicit function
> declaration.  This results in a compiler warning (also visible on the
> buildbots):
> 
> pgpool-regclass.c: In function 'MystringToQualifiedNameList':
> pgpool-regclass.c:123:7: warning: implicit declaration of function 'SplitIdentifierString' [-Wimplicit-function-declaration]
>   if (!SplitIdentifierString(rawname, '.', &namelist))
>        ^~~~~~~~~~~~~~~~~~~~~
> 
> Future compilers (e.g., Clang 16, and GCC more long term, perhaps the 14
> release in 2024) are likely not to accept implicit function declarations
> by default, so it would be nice to address that now.

Totally agreed.

> I tried to include src/include/utils/pool_relcache.h in
> pgpool-regclass.c, but that result in compile errors because the header
> interdependencies do not seem to work out:

I think what we need is, including "utils/varlena.h" (one of
PostgreSQL header files).

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp