[pgpool-hackers: 3970] Re: Simplify pgpool.conf

[Muhammad Usama]

On Wed, Jul 7, 2021 at 1:54 PM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > On 2021/07/05 11:27, Tatsuo Ishii wrote:
> >> Currently sample files of pgpool.conf under src/sample have all the
> >> configuration parameters regardless the clustering mode. For example,
> >> "replicate_select" is not applied to the streaming replication mode
> >> but it's still in the config file and maybe a noise for the streaming
> >> replication mode users. Attached is a PoC patch to remove those
> >> unnecessary parameters in the config files. For now only config files
> >> for the streaming replication mode and the snapshot isolation mode are
> >> included in the patch.
> >
> > It seems good to remove noisy parameters in the config file.
> >
> > I think it's good to comment out unnecessary parameters instead of
> > removing it completely. Like postgres. I feel that pgpool has more
> > declared parameters than postgres in the config file.
>
> One thing I am concerned is, PostgreSQL's comment represents that
> particular parameter's default value, not that the parameter is not
> necessary. But unlike Pgpool-II, PostgreSQL does not provide
> purpose-specific configuration files. Thus commenting out parameters
> could be a good idea for Pgpool-II.
>

I think removing the no-op (not applicable) parameters altogather for
specifi
clustring mode from the respective sampe config files is the right choice.

On top of that I think we should also comment out all configuration
parameters ( similar to PostgreSQL) so that the default values for each
parameter gets picked up automatically. And if user wants to change some
specific parameter value they can uncomment that particular line and change
the value as per the requirement.
IMHO Doing these two things will make the configure files less cluttered and
easier to read.

Also, If we comment out all config parameter in sample files, Then in
future we can
enhance the configuration module to store the infomation about each
parameter
that which clustering modes this variable is applicable for, and if some
config
file sets the value of a parameter that is not applicalble for current mode
we
can log the WARNING message which could be helpful to reolve confusions
in some user scenarios.


Best regards
Muhammad Usama

>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
> _______________________________________________
> pgpool-hackers mailing list
> pgpool-hackers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-hackers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20210714/a64e1749/attachment-0001.htm>