[pgpool-hackers: 3529] Re: [PATCH] Feature: Add support for an user/password input file to pg_md5

[Umar Hayat]

Hi Bo Peng,
Please find updated patch with following changes.
1. Trailing whitespaces warning removed
2. Documentation added in "doc/src/sgml/ref/pg_md5.sgml" with options
update and example usage.

Regards,
Umar Hayat

On Wed, Mar 4, 2020 at 7:40 AM Bo Peng <pengbo at sraoss.co.jp> wrote:

> hello,
>
> On Tue, 3 Mar 2020 14:13:33 +0500
> Umar Hayat <m.umarkiani at gmail.com> wrote:
>
> > Hi Bo Peng,
> > Any feedback, If this looks ok to you? I should send the same for pg_enc
> > utility.
>
> Sorry for late response.
>
> First, when I apply this patch, I found some extra trailing spaces.
>
> -----------------
> $ git apply pg_md5_input_file.diff
> pg_md5_input_file.diff:85: trailing whitespace.
> static void
> warning: 1 line adds whitespace errors.
> -----------------
>
> Could you add documentation in "doc/src/sgml/ref/pg_md5.sgml" to
> explain how to use this option?
>
> >
> > Regards
> > Umar Hayat
> > Principal Software Engineer
> > EnterpriseDB: https://www.enterprisedb.com
> >
> > On Thu, Feb 13, 2020 at 9:54 AM Bo Peng <pengbo at sraoss.co.jp> wrote:
> >
> > > Thank you for your patch.
> > > I will review your patch.
> > >
> > > On Tue, 11 Feb 2020 16:45:50 +0500
> > > Umar Hayat <m.umarkiani at gmail.com> wrote:
> > >
> > > > Hello Hackers,
> > > >
> > > > I saw "Add support for an user/password input file to pg_md5"
> enhancement
> > > > in PgPool-II TODO list
> > > > <
> > >
> https://pgpool.net/mediawiki/index.php/TODO#Add_support_for_an_user/password_input_file_to_pg_md5
> > > >,
> > > > (mentisbt-422 <https://www.pgpool.net/mantisbt/view.php?id=422>),
> so I
> > > > implemented this in pg_md5 utility. Please find attached patch for
> > > > enhancement.
> > > >
> > > > As suggested, a new --input-file option added in pg_md5. Using this
> > > option,
> > > > pg_md5 will parse the *user:password* pairs from provide file and
> will
> > > > create *user:md5xxxxxx* value in pool_passwd file.
> > > >
> > > > Regards,
> > > > Umar Hayat
> > >
> > >
> > > --
> > > Bo Peng <pengbo at sraoss.co.jp>
> > > SRA OSS, Inc. Japan
> > >
>
>
> --
> Bo Peng <pengbo at sraoss.co.jp>
> SRA OSS, Inc. Japan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200304/e139e0ae/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pg_md5_input_file_with_docs.diff
Type: application/octet-stream
Size: 7034 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200304/e139e0ae/attachment.obj>