[pgpool-hackers: 3696] Re: [patch] enable specific argument name for function in pgpool_adm

[Tatsuo Ishii]

Hi Hou,

> Hi Ishii san,
> 
>> Correction. You also need pgpool_adm--1.2--1.3.sql patch.
> 
> I update the patch for specific argument name.
> Please let me know if there is anything else that needs to be modified.

Thank you for the patch!

One thing I noticed is you use following syntax in the manual patch:

+    test=# SELECT * FROM pcp_node_info(node_id := 1, host := '', port := 11001, username := 't-ishii', password := 't-ishii');

":=" is an old syntax and I think it'd be better to use "=>" instead:

https://www.postgresql.org/docs/12/sql-syntax-calling-funcs.html

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp