[pgpool-hackers: 3338] Re: [pgpool-committers: 5790] pgpool: Second part for duplicate failover reque

[Muhammad Usama]

On Fri, May 31, 2019 at 12:51 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > Hi Ishii San
> >
> >
> >
> > On Thu, May 30, 2019 at 3:46 PM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
> >
> >> Usama,
> >>
> >> Are you going to add new parameter for this?  I vaguely recall that we
> >> agreed to add a new parameter for this in a telephone discussion.
> >>
> >
> > I am sorry somehow I might have missed that discussion and couldn't
> recall
> > it :-(
> >
> > Are you of the point of view that we should make the behavior optional by
> > adding
> > a config parameter to control it?
>
> Yes, I am. The change is rather big one, and it'd be best to give a
> chance to keep the existing behavior or not.
>

Sure, I second you on that, it's a big behavioral change and must be
configurable.

I will draft and share a patch for that.

Thanks
Best Regards
Muhammad Usama



> > Thanks
> > Best regards
> > Muhammad Usama
> >
> >
> >
> >>
> >> Best regards,
> >> --
> >> Tatsuo Ishii
> >> SRA OSS, Inc. Japan
> >> English: http://www.sraoss.co.jp/index_en.php
> >> Japanese:http://www.sraoss.co.jp
> >>
> >> From: Muhammad Usama <m.usama at gmail.com>
> >> Subject: [pgpool-committers: 5790] pgpool: Second part for
> >> [pgpool-hackers: 3295] duplicate failover reque
> >> Date: Sun, 26 May 2019 21:37:58 +0000
> >> Message-ID: <E1hV0q6-0000rS-OH at gothos.postgresql.org>
> >>
> >> > Second part for [pgpool-hackers: 3295] duplicate failover request
> ...fix
> >> >
> >> > As per the discussion on the thread [pgpool-hackers: 3295] we came to
> the
> >> > conclusion, that the master watchdog node should resign from master
> >> > responsibilities if the primary backend node gets into quarantine
> state
> >> on that.
> >> >
> >> > The commit implements the said behaviour by making the
> >> master/coordinator watchdog
> >> > node resign from its status if it fails to get the consensus for the
> >> quarantined
> >> > primary node failover, with in FAILOVER_COMMAND_FINISH_TIMEOUT(15)
> >> seconds.
> >> >
> >> > When the watchdog master resigns, because of quarantined primary node
> its
> >> > wd_priority is decreased to (-1), so that it should get the least
> >> preference
> >> > in the next election for the master/coordinator node selection. And
> once
> >> the
> >> > election is concluded the wd_priority for the node gets restored to
> the
> >> > original configured value.
> >> >
> >> > In case of failed consensus for standby node failover no action is
> taken.
> >> >
> >> > Branch
> >> > ------
> >> > master
> >> >
> >> > Details
> >> > -------
> >> >
> >>
> https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=33df0d33df1ce701f07fecaeef5b87a2707c08f2
> >> >
> >> > Modified Files
> >> > --------------
> >> > src/watchdog/watchdog.c | 47
> >> +++++++++++++++++++++++++++++++++++++++++++++--
> >> > 1 file changed, 45 insertions(+), 2 deletions(-)
> >> >
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190531/87b3bcb1/attachment.html>