[pgpool-hackers: 3325] Re: [pgpool-committers: 5734] pgpool: Fix for duplicate failover request ...

[Tatsuo Ishii]

Usama,

Since this commit regression test/buildfarm are failing:

testing 013.watchdog_failover_require_consensus... failed.

Also I think this commit seems to be against the consensus made in the
discussion [pgpool-hackers: 3295] thread.

I thought we agreed on [pgpool-hackers: 3318] so that:

---------------------------------------------------------------------
Hi Usama,

> Hi
> 
> I have drafted a patch to make the master watchdog node resigns from master
> responsibilities if it fails to get the consensus for its
> primary backend node failover request. The patch is still little short on
> testing but I want to share the early version to get
> the feedback on behaviour.
> Also with this implementation the master/coordinator node only resigns from
> being a master
> when it fails to get the consensus for the primary node failover, but in
> case of failed consensus for standby node failover
> no action is taken by the watchdog master node. Do you think master should
> also resign in this case as well ?

I don't think so because still queries can be routed to primary (or
other standby servers if there are two or more standbys).
---------------------------------------------------------------------

From: Muhammad Usama <m.usama at gmail.com>
Subject: [pgpool-committers: 5734] pgpool: Fix for [pgpool-hackers: 3295] duplicate failover request ...
Date: Wed, 15 May 2019 21:40:01 +0000
Message-ID: <E1hR1d3-0005o4-1k at gothos.postgresql.org>

> Fix for [pgpool-hackers: 3295] duplicate failover request ...
> 
> Pgpool should keep the backend health check running on quarantined nodes so
> that when the connectivity resumes, they should automatically get removed
> from the quarantine. Otherwise the temporary network glitch could send the node
> into permanent quarantine state.
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=3dd1cd3f15287ee6bb8b09f0642f99db98e9776a
> 
> Modified Files
> --------------
> src/main/health_check.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>