[pgpool-hackers: 3223] Re: watchdog lifecheck method with query mode does not work in 4.0.

[Bo Peng]

Hi Usama,

Thank you for testing the patch.

If it looks good, could you commit this one?

On Thu, 17 Jan 2019 10:43:21 +0500
Muhammad Usama <m.usama at gmail.com> wrote:

> On Thu, Jan 17, 2019 at 9:17 AM Bo Peng <pengbo at sraoss.co.jp> wrote:
> 
> > Hi Usama,
> >
> > Thank you for your patch.
> >
> > Yugo testet your patch, and give us some feedbacks.
> > Could you test the patch again?
> >
> > https://www.pgpool.net/mantisbt/view.php?id=455
> >
> >
> Sorry my bad, Yugo's patch is correct,
> I figured out the mistake, fixed that and actually tested with the correct
> version
> but unfortunately somehow attached the wrong patch file in the mail :-(
> 
> Thanks
> Best Regards
> 
> >
> > On Mon, 14 Jan 2019 19:12:48 +0500
> > Muhammad Usama <m.usama at gmail.com> wrote:
> >
> > > Hi Ishii-San
> > >
> > > On Fri, Jan 11, 2019 at 5:30 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
> > >
> > > > > Hi Ishii-San
> > > > >
> > > > > On Thu, Jan 10, 2019 at 11:52 AM Tatsuo Ishii <ishii at sraoss.co.jp>
> > > > wrote:
> > > > >
> > > > >> It is pointed out that watchdog lifecheck method with query mode
> > does
> > > > >> not work since 4.0.
> > > > >>
> > > > >> https://www.pgpool.net/mantisbt/view.php?id=455
> > > > >>
> > > > >> The cause of this is using thread unsafe function
> > > > >> get_pgpool_config_user_password(). Making it thread safe requires
> > none
> > > > >> trivial work. So I tend to agree that we disable using AES encrypted
> > > > >> password for lifecheck method = "query".
> > > > >>
> > > > >>
> > > > > Yes that's true, making get_pgpool_config_user_password thread safe
> > would
> > > > > be lot of work.
> > > > > I am thinking what if change the code and call
> > > > > get_pgpool_config_user_password() from outside the thread function
> > before
> > > > > creating
> > > > > the threads and pass in the password as the argument to the thread
> > > > > function. This way we can keep supporting the  AES encrypted
> > > > > password for lifecheck method = "query"
> > > >
> > > > Sounds a nice idea. Can you please come up with a propose patch?
> > > >
> > >
> > > Please find the attached patch which takes the
> > > get_pgpool_config_user_password()
> > > function outside the thread, as discussed upthread.
> > >
> > > Thanks
> > > Best Regards
> > > Muhammad Usama
> > >
> > >
> > > > Best regards,
> > > > --
> > > > Tatsuo Ishii
> > > > SRA OSS, Inc. Japan
> > > > English: http://www.sraoss.co.jp/index_en.php
> > > > Japanese:http://www.sraoss.co.jp
> > > >
> >
> >
> > --
> > Bo Peng <pengbo at sraoss.co.jp>
> > SRA OSS, Inc. Japan
> >
> >


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS, Inc. Japan