[pgpool-hackers: 3220] Re: watchdog lifecheck method with query mode does not work in 4.0.

[Muhammad Usama]

Hi Ishii-San

On Fri, Jan 11, 2019 at 5:30 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > Hi Ishii-San
> >
> > On Thu, Jan 10, 2019 at 11:52 AM Tatsuo Ishii <ishii at sraoss.co.jp>
> wrote:
> >
> >> It is pointed out that watchdog lifecheck method with query mode does
> >> not work since 4.0.
> >>
> >> https://www.pgpool.net/mantisbt/view.php?id=455
> >>
> >> The cause of this is using thread unsafe function
> >> get_pgpool_config_user_password(). Making it thread safe requires none
> >> trivial work. So I tend to agree that we disable using AES encrypted
> >> password for lifecheck method = "query".
> >>
> >>
> > Yes that's true, making get_pgpool_config_user_password thread safe would
> > be lot of work.
> > I am thinking what if change the code and call
> > get_pgpool_config_user_password() from outside the thread function before
> > creating
> > the threads and pass in the password as the argument to the thread
> > function. This way we can keep supporting the  AES encrypted
> > password for lifecheck method = "query"
>
> Sounds a nice idea. Can you please come up with a propose patch?
>

Please find the attached patch which takes the
get_pgpool_config_user_password()
function outside the thread, as discussed upthread.

Thanks
Best Regards
Muhammad Usama


> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190114/c1ef2569/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crash_fix.diff
Type: application/octet-stream
Size: 4126 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190114/c1ef2569/attachment.obj>