[pgpool-hackers: 3218] Re: watchdog lifecheck method with query mode does not work in 4.0.

[Bo Peng]

Hi Usama,

On Thu, 10 Jan 2019 14:19:15 +0500
Muhammad Usama <m.usama at gmail.com> wrote:

> Hi Ishii-San
> 
> On Thu, Jan 10, 2019 at 11:52 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
> 
> > It is pointed out that watchdog lifecheck method with query mode does
> > not work since 4.0.
> >
> > https://www.pgpool.net/mantisbt/view.php?id=455
> >
> > The cause of this is using thread unsafe function
> > get_pgpool_config_user_password(). Making it thread safe requires none
> > trivial work. So I tend to agree that we disable using AES encrypted
> > password for lifecheck method = "query".
> >
> >
> Yes that's true, making get_pgpool_config_user_password thread safe would
> be lot of work.
> I am thinking what if change the code and call
> get_pgpool_config_user_password() from outside the thread function before
> creating
> the threads and pass in the password as the argument to the thread
> function. This way we can keep supporting the  AES encrypted
> password for lifecheck method = "query"

Thank you.

Could you take care of this item?
https://www.pgpool.net/mantisbt/view.php?id=455

> 
> Thanks
> Best Regards
> Muhammad Usama
> 
> Any objection?
> > --
> > Tatsuo Ishii
> > SRA OSS, Inc. Japan
> > English: http://www.sraoss.co.jp/index_en.php
> > Japanese:http://www.sraoss.co.jp
> > _______________________________________________
> > pgpool-hackers mailing list
> > pgpool-hackers at pgpool.net
> > http://www.pgpool.net/mailman/listinfo/pgpool-hackers
> >


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS, Inc. Japan