[pgpool-hackers: 2370] Re: PostgreSQL 10 backward incompatibilities

[Muhammad Usama]

On Mon, May 29, 2017 at 1:42 PM, Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> >> I think these calls are only made by pgpool-worker child process, So one
> >> way could be to get the server version of each attached backend at the
> >> child startup (SELECT current_setting('server_version_num'))  and
> store the
> >> version for each backend node in respective backend data structure.
> >> And latter before sending the query we can construct the appropriate
> query
> >> by looking at the version information for that backend.
> >
> > server_version_num appeared in PostgreSQL 8.2. Since those functions
> > are only used in streaming replication, which first appeared in 9.6,
> > we can safely your method. Nice idea!
>
> Done. I have only modified pool_worker.c because those function calls
> are only used in the streaming replication delay checking. Also this
> is less invasive.
>

Yes, I also believe thats the right approach. Thanks for the fix.

Kind Regards
Muhammad Usama


>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20170529/26b6129e/attachment.html>