[pgpool-hackers: 1953] 3.6.1 build warnings on Fedora 25

[Devrim Gündüz]

Hi,

I'm getting the following warnings on Fedora 25, GCC 6.2.1. Not sure they are
important or not, so reporting here:

========================================================================================
mv -f $depbase.Tpo $depbase.Po
outfuncs.c: In function '_outFuncCall':
outfuncs.c:1201:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(strcmp(funcname,"user") == 0 ||
     ^~
========================================================================================

========================================================================================
outfuncs.c:1207:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  string_append_char(str, "(");
  ^~~~~~~~~~~~~~~~~~
========================================================================================

========================================================================================

main/main.c: In function 'main':
main/main.c:204:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(debug_level > 0 && pool_config->log_min_messages > DEBUG1)
     ^~
========================================================================================

========================================================================================
main/main.c:207:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  if (pool_config->enable_pool_hba)
  ^~
========================================================================================

========================================================================================
config/pool_config.c:1204:16: warning: 'input' defined but not used [-Wunused-function]
     static int input  (void)
                ^~~~~
========================================================================================

========================================================================================

In file included from ../src/include/pool_type.h:29:0,
                 from ../src/include/pool.h:30,
                 from utils/pool_process_reporting.c:23:
utils/pool_process_reporting.c: In function 'get_nodes':
../src/include/config.h:307:23: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'long long unsigned int' [-Wformat=]
 #define UINT64_FORMAT "%lu"
                       ^
utils/pool_process_reporting.c:1174:55: note: in expansion of macro 'UINT64_FORMAT'
     snprintf(nodes[i].delay, POOLCONFIG_MAXWEIGHTLEN, UINT64_FORMAT, bi->standby_delay);
========================================================================================                                                       ^~~~~~~~~~~~~

========================================================================================
context/pool_process_context.c: In function 'pool_coninfo_backend_pid':
context/pool_process_context.c:221:9: warning: implicit declaration of function 'ntohl' [-Wimplicit-function-declaration]
     if (ntohl(pi->connection_info[poolBE].pid) == backend_pid)
         ^~~~~
========================================================================================

========================================================================================

In file included from rewrite/pool_lobj.c:31:0:
rewrite/pool_lobj.c: In function 'pool_rewrite_lo_creat':
../src/include/pool.h:353:19: warning: implicit declaration of function 'pool_get_major_version' [-Wimplicit-function-declaration]
 #define MAJOR(p) (pool_get_major_version())
                   ^
rewrite/pool_lobj.c:173:55: note: in expansion of macro 'MAJOR'
  status = do_command(frontend, MASTER(backend), qbuf, MAJOR(backend), MASTER_CONNECTION(backend)->pid,
                                                       ^~~~~
query_cache/pool_memqcache.c:3002:14: warning: 'pool_get_buffer_pointer' defined but not used [-Wunused-function]
 static char *pool_get_buffer_pointer(POOL_INTERNAL_BUFFER *buffer)
              ^~~~~~~~~~~~~~~~~~~~~~~
protocol/pool_proto_modules.c:3105:20: warning: 'parse_before_bind' defined but not used [-Wunused-function]
 static POOL_STATUS parse_before_bind(POOL_CONNECTION *frontend,
                    ^~~~~~~~~~~~~~~~~
protocol/pool_process_query.c: In function 'read_kind_from_backend':
protocol/pool_process_query.c:3283:7: warning: unused variable 'doing_extended_message' [-Wunused-variable]
  bool doing_extended_message = false;  /* are we doing extended protocol? */
       ^~~~~~~~~~~~~~~~~~~~~~
protocol/pool_process_query.c: In function 'query_ps_status':
protocol/pool_process_query.c:3811:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(sp)
     ^~
protocol/pool_process_query.c:3816:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  while (*query && isspace(*query))
  ^~~~~
========================================================================================

========================================================================================
pool_config.c:1204:16: warning: 'input' defined but not used [-Wunused-function]
     static int input  (void)
                ^~~~~
pool_config_variables.c:3934:12: warning: 'get_max_elements_for_config_record' defined but not used [-Wunused-function]
 static int get_max_elements_for_config_record(struct config_generic* record)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pool_config_variables.c:3891:13: warning: 'value_slot_for_config_record_is_empty' defined but not used [-Wunused-function]
 static bool value_slot_for_config_record_is_empty(struct config_generic* record, int index)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pool_config_variables.c:3695:1: warning: 'ShowOption' defined but not used [-Wunused-function]
 ShowOption(struct config_generic * record, int index, int elevel)
 ^~~~~~~~~~

========================================================================================

Regards,
-- 
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20161226/3cbf15a7/attachment.sig>