[pgpool-hackers: 208] Re: Ideas for code cleanup

[Tatsuo Ishii]

> On Fri, Apr 12, 2013 at 08:40:02AM +0900, Tatsuo Ishii wrote:
>> > On Thu, Apr 11, 2013 at 11:42:59AM -0400, Bruce Momjian wrote:
>> >> > > The goal is to allow the code to be more easily understood by new
>> >> > > developers.  Would you like to see a patch?
>> >> > 
>> >> > Yes, please. Maybe you want to start from breaking main.c into several
>> >> > files?
>> >> 
>> >> Sure. I will do that now and post a patch.
>> > 
>> > I started by just moving the pid/status-file processing functions to a
>> > separate C file, so you could see how I am approaching it.  Patch
>> > attached.
>> 
>> Thakns. I briefly looked into this and noticed that you modified
>> Makefile.in.  You should modify Makefile.am because Makefile.in is
>> generated automatically from Makefile.am.
> 
> Good catch.  Updated patch attached.

Thanks. Compiled without problem and I can start pgpool-II.

BTW, we are planning to remove "old"(non memory based) query cache in
the near future. I think you can do it in the process of refactoring.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp