[pgpool-hackers: 206] Re: Ideas for code cleanup

Tatsuo Ishii ishii at postgresql.org
Fri Apr 12 08:40:02 JST 2013


> On Thu, Apr 11, 2013 at 11:42:59AM -0400, Bruce Momjian wrote:
>> > > The goal is to allow the code to be more easily understood by new
>> > > developers.  Would you like to see a patch?
>> > 
>> > Yes, please. Maybe you want to start from breaking main.c into several
>> > files?
>> 
>> Sure. I will do that now and post a patch.
> 
> I started by just moving the pid/status-file processing functions to a
> separate C file, so you could see how I am approaching it.  Patch
> attached.

Thakns. I briefly looked into this and noticed that you modified
Makefile.in.  You should modify Makefile.am because Makefile.in is
generated automatically from Makefile.am.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list