[pgpool-hackers: 201] Re: Ideas for code cleanup

[Bruce Momjian]

On Thu, Apr 11, 2013 at 10:42:24AM +0900, Tatsuo Ishii wrote:
> >> Sounds like a good idea.
> > 
> > OK, how should I proceed?  I have a github account to which I have
> > already pushed some branches:
> > 
> > 	https://github.com/bmomjian/pgpool2/branches
> 
> I think you'd better to follow PostgreSQL way: first you propose how
> you want to break C files and adding subdirectores. Using github
> itself seems a godd idea.

OK, I will send that as a separate email.

> > The 'doc' branch has some English documentation wording improvements,
> > and the 'code' branch has some code and comment adjustments and
> > questions.
> 
> It seems doc improvements can be applied to pgpool master
> repository. If so, please post patch when you are ready.

Documentation and code patches attached.

> >> > I was also thinking that running pgindent over the code would help make
> >> > it more consistent.
> >> 
> >> This sounds also good. We have been following PostgreSQL coding style
> >> but we did not use pgindent. So there may be places where the rule is
> >> not respected.
> > 
> > I can create a git branch with just the pgindent output, but it will be
> > a large patch.  Do you want it now?  Should I create a git branch for
> > it?
> > 
> > The pgindent changes will be major so it would be best to do that first
> > --- then I can start working on the function location adjustments.
> 
> Ok, let's run pgindent when 3.5 developments starts.

OK, makes sense.

-- 
  Bruce Momjian  <bruce at momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +
-------------- next part --------------
A non-text attachment was scrubbed...
Name: doc.diff
Type: text/x-diff
Size: 47651 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20130410/1982e646/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: code.diff
Type: text/x-diff
Size: 7842 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20130410/1982e646/attachment-0003.bin>