[pgpool-hackers: 198] Re: Ideas for code cleanup

Tatsuo Ishii ishii at postgresql.org
Thu Apr 11 09:49:24 JST 2013


Hi Bruce,

welcome to the pgpool world!

> Hi, everyone.  I am new to pgpool hackers, but not new to Postgres.

Of course:-) you are one of the PostgreSQL core team, as everyone knows.

> I am hoping to get involved in pgpool development.  I have looked over a
> lot of the source code at this point, and am reading through the
> documentation in English.
> 
> The code quality seems very good.
> 
> I was wondering if there was any interest in improving the code layout
> of pgpool by splitting up some of the larger C files into smaller ones,
> and adding some subdirectories.  I think that will make it easier for
> new users to get involved in pgpool development.  

Sounds like a good idea.

> I was also thinking that running pgindent over the code would help make
> it more consistent.

This sounds also good. We have been following PostgreSQL coding style
but we did not use pgindent. So there may be places where the rule is
not respected.

> I can do the work if people are interested in these changes.

+1.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list