[pgpool-committers: 8014] pgpool: Fix for bug-731: Fails to execute follow_primary_command..

Muhammad Usama m.usama at gmail.com
Fri Sep 10 19:58:52 JST 2021


Fix for bug-731: Fails to execute follow_primary_command..

It was a segmentation fault happening because of a silly coding mistake in
parse_wd_exec_cluster_command_json() function.
The problem was the WDExecCommandArg** arg for returning the argument list
was not getting populated properly.
As part of the fix, to get rid of complexity and confusion, I have changed
the function signature to accept List* type argument for returning the
parsed command args instead of an array and its length.

Thanks to Bo Peng, Emond Papegaaij and Tatsuo Ishi for reviewing
and testing the fix

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=3b1551fbc7a6c853b43b4a7cfeec4a2bfd218ae6
Author: Muhammad Usama <m.usama at highgo.ca>

Modified Files
--------------
src/include/watchdog/wd_internal_commands.h |  4 +--
src/include/watchdog/wd_json_data.h         |  7 ++--
src/pcp_con/pcp_worker.c                    | 12 ++++---
src/watchdog/watchdog.c                     | 55 +++++++++++++++--------------
src/watchdog/wd_internal_commands.c         | 17 +++++----
src/watchdog/wd_json_data.c                 | 54 +++++++++++++++++-----------
6 files changed, 85 insertions(+), 64 deletions(-)



More information about the pgpool-committers mailing list