[pgpool-committers: 7091] Re: pgpool: Feature: Import PostgreSQL 13 beta3 new parser.

[Bo Peng]

Hi Usama,

On Tue, 8 Sep 2020 13:02:04 +0500
Muhammad Usama <m.usama at gmail.com> wrote:

> Hi Peng,
> 
> 
> -               next = lnext(cell);
> +               if (!session_context->pending_messages)
> +                       return;
> +
> This change in *context/pool_session_context.c*
> is adding a return statement without the value while the function is
> supposed
> to return a bool value.
> 
> This is causing a build failure on some platforms. Can you please take
> care of this?
> 
> This same change is made in following functions
> can_query_context_destroy
> pool_pending_message_get_message_num_by_backend_id
> pool_pending_message_get

Thank you for pointing out the error.
I have fixed and committed it:
https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=30d10e63ce8ef009257a154b28bf8846b38cf0e6

Regards, 
 
> On Mon, Sep 7, 2020 at 5:53 AM Bo Peng <pengbo at sraoss.co.jp> wrote:
> 
> > Feature: Import PostgreSQL 13 beta3 new parser.
> >
> > Major changes of PostgreSQL 13 parser include:
> >
> > - Remove an object's dependency on an extension
> >
> >   ALTER TRIGGER ... NO DEPENDS ON EXTENSION ...
> >   ALTER FUNCTION ... NO DEPENDS ON EXTENSION ...
> >
> > - Allow FETCH FIRST to use WITH TIES
> >
> >   FETCH FIRST ... WITH TIES
> >
> > - Add ALTER TABLE clause DROP EXPRESSION
> >
> >   ALTER TABLE ... DROP EXPRESSION
> >
> > - Allow setting statistics target for extended statistics
> >
> >   ALTER STATISTICS ... SET STATISTICS
> >
> > - Allow ALTER VIEW to rename view columns
> >
> >   ALTER VIEW ... RENAME COLUMN ... TO ...
> >
> > - Add CREATE DATABASE clause LOCALE option
> >
> >   CREATE DATABASE ... LOCALE
> >
> > - Add DROP DATABASE clause WITH FORCE option
> >
> >   DROP DATABASE ... WITH (force)
> >
> > - Add VACUUM clause PARALLEL option
> >
> >   VACUUM (PARALLEL 1) ...
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> >
> > https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=a8cc1e26cc204a49bea47eea05c711a981c17484
> >
> > Modified Files
> > --------------
> > configure                                          |   292 +
> > configure.ac                                       |     2 +-
> > src/auth/pool_hba.c                                |    12 +-
> > src/context/pool_session_context.c                 |    22 +-
> > src/include/parser/gramparse.h                     |     4 +-
> > src/include/parser/keywords.h                      |     4 +-
> > src/include/parser/kwlist.h                        |    12 +-
> > src/include/parser/kwlist_d.h                      |   812 +-
> > src/include/parser/kwlookup.h                      |     4 +-
> > src/include/parser/makefuncs.h                     |     6 +-
> > src/include/parser/nodes.h                         |    26 +-
> > src/include/parser/parsenodes.h                    |    66 +-
> > src/include/parser/parser.h                        |     4 +-
> > src/include/parser/pg_class.h                      |    59 +-
> > src/include/parser/pg_config_manual.h              |    55 +-
> > src/include/parser/pg_list.h                       |   575 +-
> > src/include/parser/pg_trigger.h                    |     5 +-
> > src/include/parser/pg_wchar.h                      |    98 +-
> > src/include/parser/pool_parser.h                   |    10 +-
> > src/include/parser/primnodes.h                     |    56 +-
> > src/include/parser/scanner.h                       |    24 +-
> > src/include/parser/scansup.h                       |     4 +-
> > src/include/parser/stringinfo.h                    |    11 +-
> > src/include/parser/value.h                         |     4 +-
> > src/parser/copyfuncs.c                             |   161 +-
> > src/parser/gram.c                                  | 61107
> > ++++++++++---------
> > src/parser/gram.h                                  |  1873 +-
> > src/parser/gram.y                                  |   481 +-
> > src/parser/gram_minimal.c                          | 60295
> > +++++++++---------
> > src/parser/gram_minimal.h                          |  1873 +-
> > src/parser/gram_minimal.y                          |   482 +-
> > src/parser/gram_template.y                         |   481 +-
> > src/parser/keywords.c                              |     4 +-
> > src/parser/kwlookup.c                              |     4 +-
> > src/parser/list.c                                  |   914 +-
> > src/parser/makefuncs.c                             |    18 +-
> > src/parser/nodes.c                                 |     4 +-
> > src/parser/outfuncs.c                              |    12 +-
> > src/parser/parser.c                                |   291 +-
> > src/parser/scan.c                                  |  1530 +-
> > src/parser/scan.l                                  |   543 +-
> > src/parser/scansup.c                               |     6 +-
> > src/parser/snprintf.c                              |    12 +-
> > src/parser/value.c                                 |     4 +-
> > src/parser/wchar.c                                 |    76 +-
> > src/protocol/CommandComplete.c                     |     6 +-
> > .../tests/010.rewrite_timestamp/timestamp/Makefile |     2 +-
> > 47 files changed, 67559 insertions(+), 64787 deletions(-)
> >
> > _______________________________________________
> > pgpool-committers mailing list
> > pgpool-committers at pgpool.net
> > http://www.pgpool.net/mailman/listinfo/pgpool-committers
> >
> 
> 
> -- 
> ...
> Muhammad Usama
> Highgo Software (Canada/China/Pakistan)
> URL : http://www.highgo.ca
> ADDR: 10318 WHALLEY BLVD, Surrey, BC


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS, Inc. Japan