[pgpool-committers: 6207] Re: pgpool: Adding new wd_cli utility

[Muhammad Usama]

On Tue, Sep 24, 2019 at 1:22 PM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Hi Usama,
>
> But actually your commit deeply modifies not only watchdog, but other
> modules.  I worry about the side effects those modificarions other
> than watchdog modules.
>

The modifications other than in the watchdog module are mostly cosmetic in
nature and done to segregate the socket stream from pool stream.
Having said that, I agree with your point that there could be some
unforeseen side effects and its better to keep it for the next version.

Thanks
Best Regards
Muhammad Usama


> > Hi Ishii-San,
> >
> > Although we are very late in the release cycle. But I was wondering since
> > wd_cli is a separate utility so we can also push it to the V4_1_STABLE
> > branch
> > so that we can release it along with 4.1 GA, otherwise, it will take
> quite
> > a long before someone is able to use it.
> >
> > What are your thoughts?
> >
> > Best Regards
> > Muhammad Usama
> >
> > On Tue, Sep 24, 2019 at 1:08 PM Muhammad Usama <m.usama at gmail.com>
> wrote:
> >
> >>
> >>
> >> On Tue, Sep 24, 2019 at 12:50 PM Tatsuo Ishii <ishii at sraoss.co.jp>
> wrote:
> >>
> >>> > Hi Tatsuo
> >>> >
> >>> > I have not changed/removed the 'lifecheck started" message and I am
> >>> getting
> >>> > clean
> >>> > regression including this test case.
> >>> >
> >>> > testing 028.watchdog_enable_consensus_with_half_votes...ok.
> >>> > out of 1 ok:1 failed:0 timeout:0
> >>> >
> >>> > Can you send me the pgpool.log for a failed test case? It could be
> some
> >>> > other issue that was
> >>> > preventing the pgpool-II to start up in time.
> >>>
> >>> Strange. This time the test has passed. Will notify you if I get the
> >>> failure again (along with pgpool.log).
> >>>
> >>> Sure, Thanks
> >>
> >>
> >>> BTW, I get compiler warning after your commit:
> >>>
> >>> psprintf.c:139:45: warning: implicit declaration of function
> ‘strerror’;
> >>> did you mean ‘perror’? [-Wimplicit-function-declaration]
> >>>    fprintf(stderr, "vsnprintf failed: %s\n", strerror(errno));
> >>>                                              ^~~~~~~~
> >>>                                              perror
> >>> psprintf.c:139:39: warning: format ‘%s’ expects argument of type ‘char
> >>> *’, but argument 3 has type ‘int’ [-Wformat=]
> >>>    fprintf(stderr, "vsnprintf failed: %s\n", strerror(errno));
> >>>                                       ~^     ~~~~~~~~~~~~~~~
> >>>                                       %d
> >>>
> >>> Sorry about that. I will take care of this one.
> >>
> >>
> >>> Best regards,
> >>> --
> >>> Tatsuo Ishii
> >>> SRA OSS, Inc. Japan
> >>> English: http://www.sraoss.co.jp/index_en.php
> >>> Japanese:http://www.sraoss.co.jp
> >>>
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-committers/attachments/20190924/2ad823e8/attachment.html>