[pgpool-committers: 4156] pgpool: Fix for [pgpool-general: 5621] pgpool 3.6.4 failover

[Muhammad Usama]

Fix for [pgpool-general: 5621] pgpool 3.6.4 failover

Failover() function should be executed with health check alarm disabled

The reason is the find primary node and health check uses the same function to
make a connection to the backends, and the backend connect function has a built
in logic to bail out with the timeout error when the health check alarm occurs.
Now the problem is if the failover() is executed while the health check alarm is
still running, Their is a strong possibility that the find primary node function
may find the health check timer already expired and exit without locating the
new primary node.

The commit also fixes a spelling mistake in the function name and
enum definition. The typo was identified by Ishii-San

Branch
------
V3_5_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6586da86033de01d1ee60c65b8a5e5d9956f84dc

Modified Files
--------------
src/include/pool.h      |  2 +-
src/main/pgpool_main.c  | 28 ++++++++++++++++++----------
src/watchdog/watchdog.c |  4 ++--
3 files changed, 21 insertions(+), 13 deletions(-)