[pgpool-committers: 4220] Re: pgpool: Fix for [pgpool-hackers: 2400] Garbage output

[Muhammad Usama]

Hi Ishii-San

Despite my utmost efforts I am not able to reproduce the issue, I have gone
through the watchdog code and also have used emacs shell but still no luck.
My hunch is that the garbage character is emitted somehow by the watchdog
test script and not by the watchdog itself,
So I have made few changes in the test script.
Can you please try running the watchdog test case by pulling the latest
regression related changes I have just pushed
because other than that I am really clueless on this at the point.

Thanks
Best Regards
Muhammad Usama


On Tue, Jul 25, 2017 at 5:21 AM, Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Usama,
>
> I have taken look at a little bit. Since the regression script
> redirects everything (stdout and stderr) of the out of the test driver
> (in this case src/test/regress/tests/004.watchdog/test.sh) to
> src/regression/log/004.watchdog, the garbase must not come from stdout
> or stderr. It is likely the garbage is put to the tty device directly.
>
> By changing regress.sh so that it does not redirect everything,
>
>         #       timeout $TIMEOUT ./test.sh > $log/$i 2>&1
>         timeout $TIMEOUT ./test.sh
>
> and run the test, I found the garbage was produced right before line
> 42 of test.sh:
> echo -n "creating standby pgpool..."
>
> So my guess is, while master watchdog is starting up, something is
> writing a garbage to the tty device directly.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
> > Usama,
> >
> > Thanks for the commit. Unfortunately I still get the garbage output.
> >
> > t-ishii at localhost: ./regress.sh 004
> > creating pgpool-II temporary installation ...
> > moving pgpool_setup to temporary installation path ...
> > using pgpool-II at /home/t-ishii/work/pgpool-II/
> current/pgpool2/src/test/regression/temp/installed
> > *************************
> > REGRESSION MODE : install
> > PGPOOL-II       : /home/t-ishii/work/pgpool-II/current/pgpool2/src/test/
> regression/temp/installed
> > PostgreSQL bin  : /usr/local/pgsql/bin
> > pgbench         : /usr/local/pgsql/bin/pgbench
> > PostgreSQL jdbc : /usr/local/pgsql/share/postgresql-9.2-1003.jdbc4.jar
> > *************************
> > testing 004.watchdog... ok.
> > out of 1 ok:1 failed:0 timeout:0
> > --
> > Tatsuo Ishii
> > SRA OSS, Inc. Japan
> > English: http://www.sraoss.co.jp/index_en.php
> > Japanese:http://www.sraoss.co.jp
> >
> > From: Muhammad Usama <m.usama at gmail.com>
> > Subject: [pgpool-committers: 4110] pgpool: Fix for [pgpool-hackers:
> 2400] Garbage output
> > Date: Thu, 06 Jul 2017 19:26:03 +0000
> > Message-ID: <E1dTCPb-0001Gd-HQ at gothos.postgresql.org>
> >
> >> Fix for [pgpool-hackers: 2400] Garbage output
> >>
> >> Mostly the log messages fixes and few code cleanups.
> >>
> >> Branch
> >> ------
> >> master
> >>
> >> Details
> >> -------
> >> https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=
> 2b9d8aca0852aea9bcb0dc55068505978b44bbcd
> >>
> >> Modified Files
> >> --------------
> >> src/include/watchdog/wd_ipc_defines.h |  1 -
> >> src/watchdog/watchdog.c               | 99
> ++++++++++++++++++++++++-----------
> >> 2 files changed, 69 insertions(+), 31 deletions(-)
> >>
> > _______________________________________________
> > pgpool-committers mailing list
> > pgpool-committers at pgpool.net
> > http://www.pgpool.net/mailman/listinfo/pgpool-committers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-committers/attachments/20170824/be8253ce/attachment-0001.html>