[pgpool-committers: 3336] pgpool: Fix usage of wait(2) in pgpool main process
Tatsuo Ishii
ishii at postgresql.org
Thu Jul 7 15:55:47 JST 2016
Fix usage of wait(2) in pgpool main process
Per [pgpool-hackers: 1444]. Here is the copy of the message:
Hi Usama,
I have noticed that the usage of wait(2) in pgpool main could cause
infinite wait in the system call.
/* wait for all children to exit */
do
{
wpid = wait(NULL);
}while (wpid > 0 || (wpid == -1 && errno == EINTR));
When child process dies, SIGCHLD signal is raised and wait(2) knows
the event. However, multiple child death does not necessarily creates
exact same number of SIGCHLD signal as the number of dead children and
wait(2) could wait for an event which never happens in this case. I
actually encountered this situation while testing pgpool-II. Solution
is, to use waitpid(2) instead of wait(2).
Branch
------
V3_5_STABLE
Details
-------
http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=e94b63b160064f3687b7d2738bc43ae4a6d7cf9c
Modified Files
--------------
src/main/pgpool_main.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
More information about the pgpool-committers
mailing list