<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ks_c_5601-1987">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:DengXian;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:DengXian;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:DengXian;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="#0563C1" vlink="#954F72" style="word-wrap:break-word;text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hello and Happy new year :),<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I found the regression test case "075.detach_primary_left_down_node" was not working correctly.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">If the "./startall" command on line 23 failed for some reasons (port occupancy for example), the "$PGBIN/psql -c "show pool_nodes" test" command on line 36 would report errors resulting in "$PGBIN/psql -c "show pool_nodes"
test|grep down" returned 1.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">So this test case would finally output "ok" even if we had not start the instance. The test purpose is not achieved. The detailed logs are as follows</span>£º<span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">==========================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">waiting for server to start....26108 2022-01-07 19:17:00 JST LOG: redirecting log output to logging collector process<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">26108 2022-01-07 19:17:00 JST HINT: Future log output will appear in directory "log".<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">stopped waiting<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">pg_ctl: could not start server<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Examine the log output.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">waiting for server to start....26112 2022-01-07 19:17:00 JST LOG: redirecting log output to logging collector process<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">26112 2022-01-07 19:17:00 JST HINT: Future log output will appear in directory "log".<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">stopped waiting<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">pg_ctl: could not start server<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Examine the log output.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">waiting for server to start....26116 2022-01-07 19:17:00 JST LOG: redirecting log output to logging collector process<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">26116 2022-01-07 19:17:00 JST HINT: Future log output will appear in directory "log".<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">stopped waiting<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">pg_ctl: could not start server<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Examine the log output.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">waiting for server to start....26126 2022-01-07 19:17:01 JST LOG: redirecting log output to logging collector process<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">26126 2022-01-07 19:17:01 JST HINT: Future log output will appear in directory "log".<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">stopped waiting<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">pg_ctl: could not start server<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Examine the log output.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">pcp_detach_node -- Command Successful<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">starting to check follow primary results: Fri Jan 7 19:17:43 JST 2022<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">psql: error: FATAL: database "test" does not exist<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">test succeeded<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">==========================<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Fixed this by adding the STDOUT redirection and keyword error's judgment, details can be seen in the "0001-fix-regression-test-075.patch" attached.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Qiang Lingjie<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</body>
</html>